So painful. Poor Sam's massive confusion to what was real and what wasn't and Dean trying his best to be the parent John would never allow himself to be.

I think your portrayal of John was pretty close to what's been said in canon. The show has often mentioned his obsession (which came out particularly clearly in IMTOD), how hard he was on the boys and that he was a mean drunk but he also loved them and his intention was to keep them safe even though he constantly put them in harm's way. His logic is hard to follow.